Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/kendra_experience: new resource #25315

Merged
merged 3 commits into from
Jun 22, 2022
Merged

r/kendra_experience: new resource #25315

merged 3 commits into from
Jun 22, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jun 14, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13367

Output from acceptance testing (must be run in Organizations-only account):

$ make testacc TESTARGS='-run=TestAccKendra_serial/Experience' PKG=kendra ACCTEST_TIMEOUT=250m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 20  -run=TestAccKendra_serial/Experience -timeout 250m
=== RUN   TestAccKendra_serial
=== RUN   TestAccKendra_serial/Experience
=== RUN   TestAccKendra_serial/Experience/Configuration_ContentSourceConfigurationWithUserIdentityConfigurationRemoved
=== RUN   TestAccKendra_serial/Experience/disappears
=== RUN   TestAccKendra_serial/Experience/Description
=== RUN   TestAccKendra_serial/Experience/RoleARN
=== RUN   TestAccKendra_serial/Experience/Configuration_ContentSourceConfiguration_DirectPutContent
=== RUN   TestAccKendra_serial/Experience/Configuration_ContentSourceConfiguration_FaqIDs
=== RUN   TestAccKendra_serial/Experience/Configuration_ContentSourceConfiguration_updateFaqIDs
=== RUN   TestAccKendra_serial/Experience/Configuration_UserIdentityConfigurationWithContentSourceConfigurationRemoved
=== RUN   TestAccKendra_serial/Experience/basic
=== RUN   TestAccKendra_serial/Experience/Name
=== RUN   TestAccKendra_serial/Experience/Configuration_UserIdentityConfiguration
=== RUN   TestAccKendra_serial/Experience/Configuration_ContentSourceConfigurationAndUserIdentityConfiguration
--- PASS: TestAccKendra_serial (13975.64s)
    --- PASS: TestAccKendra_serial/Experience (13975.64s)
        --- PASS: TestAccKendra_serial/Experience/Configuration_ContentSourceConfigurationWithUserIdentityConfigurationRemoved (1053.06s)
        --- PASS: TestAccKendra_serial/Experience/disappears (1024.74s)
        --- PASS: TestAccKendra_serial/Experience/Description (962.61s)
        --- PASS: TestAccKendra_serial/Experience/RoleARN (2178.57s)
        --- PASS: TestAccKendra_serial/Experience/Configuration_ContentSourceConfiguration_DirectPutContent (1020.81s)
        --- PASS: TestAccKendra_serial/Experience/Configuration_ContentSourceConfiguration_FaqIDs (932.01s)
        --- PASS: TestAccKendra_serial/Experience/Configuration_ContentSourceConfiguration_updateFaqIDs (1021.93s)
        --- PASS: TestAccKendra_serial/Experience/Configuration_UserIdentityConfigurationWithContentSourceConfigurationRemoved (2048.82s)
        --- PASS: TestAccKendra_serial/Experience/basic (1036.53s)
        --- PASS: TestAccKendra_serial/Experience/Name (1877.70s)
        --- PASS: TestAccKendra_serial/Experience/Configuration_UserIdentityConfiguration (1075.86s)
        --- PASS: TestAccKendra_serial/Experience/Configuration_ContentSourceConfigurationAndUserIdentityConfiguration (1696.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kendra	13978.867s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/kendra Issues and PRs that pertain to the kendra service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 14, 2022
@anGie44 anGie44 added the new-resource Introduces a new resource. label Jun 14, 2022
@anGie44 anGie44 mentioned this pull request Jun 14, 2022
Closed
@anGie44 anGie44 force-pushed the f-kendra-experience branch 6 times, most recently from 8747003 to efaf563 Compare June 15, 2022 03:48
anGie44
anGie44 commented Jun 15, 2022
View reviewed changes
internal/service/kendra/experience.go
},
},
},
"description": {
Copy link
Contributor Author

@anGie44 anGie44 Jun 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important note: description for some reason cannot be changed back to an empty string once configured. this looks to be true both with the AWS SDK and in the console; see comment in customizediff below

@anGie44 anGie44 force-pushed the f-kendra-experience branch from efaf563 to b44a080 Compare June 19, 2022 03:54
@anGie44 anGie44 force-pushed the f-kendra-experience branch from b44a080 to f89e90d Compare June 19, 2022 03:58
anGie44 added a commit that referenced this pull request Jun 19, 2022
@anGie44
Update CHANGELOG for #25315
f6a2a29
@anGie44 anGie44 force-pushed the f-kendra-experience branch from f89e90d to f6a2a29 Compare June 19, 2022 04:03
anGie44 added a commit that referenced this pull request Jun 21, 2022
@anGie44
Update CHANGELOG for #25315
149d3b2
@anGie44 anGie44 force-pushed the f-kendra-experience branch from f6a2a29 to 149d3b2 Compare June 21, 2022 01:36
@anGie44 anGie44 force-pushed the f-kendra-experience branch from 149d3b2 to 557e4b7 Compare June 21, 2022 13:32
@anGie44 anGie44 force-pushed the f-kendra-experience branch from 557e4b7 to c9f4511 Compare June 21, 2022 13:33
@github-actions github-actions bot added service/acmpca Issues and PRs that pertain to the acmpca service. service/apprunner Issues and PRs that pertain to the apprunner service. service/configservice Issues and PRs that pertain to the configservice service. service/lambda Issues and PRs that pertain to the lambda service. labels Jun 21, 2022
anGie44 added a commit that referenced this pull request Jun 21, 2022
@anGie44
Update CHANGELOG for #25315
e566c18
@anGie44 anGie44 force-pushed the f-kendra-experience branch from c9f4511 to e566c18 Compare June 21, 2022 13:40
@github-actions github-actions bot removed service/lambda Issues and PRs that pertain to the lambda service. service/apprunner Issues and PRs that pertain to the apprunner service. service/configservice Issues and PRs that pertain to the configservice service. service/acmpca Issues and PRs that pertain to the acmpca service. labels Jun 21, 2022
@anGie44 anGie44 force-pushed the f-kendra-experience branch from e566c18 to 381b704 Compare June 21, 2022 16:24
@anGie44 anGie44 force-pushed the f-kendra-experience branch from 381b704 to db1c2a3 Compare June 21, 2022 16:55
@anGie44 anGie44 force-pushed the f-kendra-experience branch 3 times, most recently from 779156c to 7289046 Compare June 22, 2022 05:00
@anGie44 anGie44 marked this pull request as ready for review June 22, 2022 05:02
@anGie44 anGie44 force-pushed the f-kendra-experience branch from 7289046 to 83599ba Compare June 22, 2022 06:41
@ewbankkit ewbankkit self-assigned this Jun 22, 2022
ewbankkit
ewbankkit approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccKendra_serial/Experience' PKG=kendra
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 20  -run=TestAccKendra_serial/Experience -timeout 360m
=== RUN   TestAccKendra_serial
=== RUN   TestAccKendra_serial/Experience
=== RUN   TestAccKendra_serial/Experience/Configuration_ContentSourceConfiguration_updateFaqIDs
=== RUN   TestAccKendra_serial/Experience/Configuration_UserIdentityConfiguration
    experience_test.go:387: Environment variable AWS_IDENTITY_STORE_USER_ID is not set
=== RUN   TestAccKendra_serial/Experience/basic
=== RUN   TestAccKendra_serial/Experience/disappears
=== RUN   TestAccKendra_serial/Experience/Description
=== RUN   TestAccKendra_serial/Experience/Name
=== RUN   TestAccKendra_serial/Experience/RoleARN
=== RUN   TestAccKendra_serial/Experience/Configuration_ContentSourceConfiguration_FaqIDs
=== RUN   TestAccKendra_serial/Experience/Configuration_ContentSourceConfigurationWithUserIdentityConfigurationRemoved
    experience_test.go:471: Environment variable AWS_IDENTITY_STORE_USER_ID is not set
=== RUN   TestAccKendra_serial/Experience/Configuration_ContentSourceConfiguration_DirectPutContent
=== RUN   TestAccKendra_serial/Experience/Configuration_ContentSourceConfigurationAndUserIdentityConfiguration
    experience_test.go:428: Environment variable AWS_IDENTITY_STORE_USER_ID is not set
=== RUN   TestAccKendra_serial/Experience/Configuration_UserIdentityConfigurationWithContentSourceConfigurationRemoved
    experience_test.go:524: Environment variable AWS_IDENTITY_STORE_USER_ID is not set
--- PASS: TestAccKendra_serial (11235.91s)
    --- PASS: TestAccKendra_serial/Experience (11235.91s)
        --- PASS: TestAccKendra_serial/Experience/Configuration_ContentSourceConfiguration_updateFaqIDs (1129.67s)
        --- SKIP: TestAccKendra_serial/Experience/Configuration_UserIdentityConfiguration (0.00s)
        --- PASS: TestAccKendra_serial/Experience/basic (992.24s)
        --- PASS: TestAccKendra_serial/Experience/disappears (1559.66s)
        --- PASS: TestAccKendra_serial/Experience/Description (1129.49s)
        --- PASS: TestAccKendra_serial/Experience/Name (1931.63s)
        --- PASS: TestAccKendra_serial/Experience/RoleARN (1496.54s)
        --- PASS: TestAccKendra_serial/Experience/Configuration_ContentSourceConfiguration_FaqIDs (1052.01s)
        --- SKIP: TestAccKendra_serial/Experience/Configuration_ContentSourceConfigurationWithUserIdentityConfigurationRemoved (0.00s)
        --- PASS: TestAccKendra_serial/Experience/Configuration_ContentSourceConfiguration_DirectPutContent (1944.67s)
        --- SKIP: TestAccKendra_serial/Experience/Configuration_ContentSourceConfigurationAndUserIdentityConfiguration (0.00s)
        --- SKIP: TestAccKendra_serial/Experience/Configuration_UserIdentityConfigurationWithContentSourceConfigurationRemoved (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kendra	11242.273s

Non-main account:

% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccKendra_serial/Experience' PKG=kendra
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 20  -run=TestAccKendra_serial/Experience -timeout 360m
=== RUN   TestAccKendra_serial
=== RUN   TestAccKendra_serial/Experience
=== RUN   TestAccKendra_serial/Experience/Configuration_ContentSourceConfigurationWithUserIdentityConfigurationRemoved
    experience_test.go:471: Environment variable AWS_IDENTITY_STORE_USER_ID is not set
=== RUN   TestAccKendra_serial/Experience/Configuration_UserIdentityConfigurationWithContentSourceConfigurationRemoved
    experience_test.go:524: Environment variable AWS_IDENTITY_STORE_USER_ID is not set
=== RUN   TestAccKendra_serial/Experience/Name
    acctest.go:726: this AWS account must be the management account of an AWS Organization
=== RUN   TestAccKendra_serial/Experience/Configuration_ContentSourceConfiguration_FaqIDs
    acctest.go:726: this AWS account must be the management account of an AWS Organization
=== RUN   TestAccKendra_serial/Experience/Configuration_ContentSourceConfigurationAndUserIdentityConfiguration
    experience_test.go:428: Environment variable AWS_IDENTITY_STORE_USER_ID is not set
=== RUN   TestAccKendra_serial/Experience/RoleARN
    acctest.go:726: this AWS account must be the management account of an AWS Organization
=== RUN   TestAccKendra_serial/Experience/Configuration_ContentSourceConfiguration_DirectPutContent
    acctest.go:726: this AWS account must be the management account of an AWS Organization
=== RUN   TestAccKendra_serial/Experience/Configuration_ContentSourceConfiguration_updateFaqIDs
    acctest.go:726: this AWS account must be the management account of an AWS Organization
=== RUN   TestAccKendra_serial/Experience/Configuration_UserIdentityConfiguration
    experience_test.go:387: Environment variable AWS_IDENTITY_STORE_USER_ID is not set
=== RUN   TestAccKendra_serial/Experience/basic
    acctest.go:726: this AWS account must be the management account of an AWS Organization
=== RUN   TestAccKendra_serial/Experience/disappears
    acctest.go:726: this AWS account must be the management account of an AWS Organization
=== RUN   TestAccKendra_serial/Experience/Description
    acctest.go:726: this AWS account must be the management account of an AWS Organization
--- PASS: TestAccKendra_serial (8.76s)
    --- PASS: TestAccKendra_serial/Experience (8.76s)
        --- SKIP: TestAccKendra_serial/Experience/Configuration_ContentSourceConfigurationWithUserIdentityConfigurationRemoved (0.00s)
        --- SKIP: TestAccKendra_serial/Experience/Configuration_UserIdentityConfigurationWithContentSourceConfigurationRemoved (0.00s)
        --- SKIP: TestAccKendra_serial/Experience/Name (1.62s)
        --- SKIP: TestAccKendra_serial/Experience/Configuration_ContentSourceConfiguration_FaqIDs (0.10s)
        --- SKIP: TestAccKendra_serial/Experience/Configuration_ContentSourceConfigurationAndUserIdentityConfiguration (0.00s)
        --- SKIP: TestAccKendra_serial/Experience/RoleARN (2.08s)
        --- SKIP: TestAccKendra_serial/Experience/Configuration_ContentSourceConfiguration_DirectPutContent (0.79s)
        --- SKIP: TestAccKendra_serial/Experience/Configuration_ContentSourceConfiguration_updateFaqIDs (0.09s)
        --- SKIP: TestAccKendra_serial/Experience/Configuration_UserIdentityConfiguration (0.00s)
        --- SKIP: TestAccKendra_serial/Experience/basic (2.96s)
        --- SKIP: TestAccKendra_serial/Experience/disappears (0.08s)
        --- SKIP: TestAccKendra_serial/Experience/Description (1.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kendra	20.594s

@anGie44 anGie44 added this to the v4.20.0 milestone Jun 22, 2022
@anGie44 anGie44 merged commit 1fb1296 into main Jun 22, 2022
@anGie44 anGie44 deleted the f-kendra-experience branch June 22, 2022 19:41
@ewbankkit ewbankkit removed their assignment Jun 22, 2022
github-actions bot pushed a commit that referenced this pull request Jun 22, 2022
Update CHANGELOG.md for #25315
a7f8b1d
@github-actions
Copy link

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/kendra Issues and PRs that pertain to the kendra service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anGie44 @ewbankkit